Fix broken tests in PHP 5.5 #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for #1209 |
rclations
force-pushed
the
1209-fix-broken-tests
branch
from
c71daf6
to
5b13f54
Compare
rclations
force-pushed
the
1209-fix-broken-tests
branch
from
4466c63
to
3962651
Compare
…ticket/26234#comment:4 check if array before running array_merge
rclations
force-pushed
the
1209-fix-broken-tests
branch
from
3962651
to
4c09024
Compare
|
all checks passing! read to go! |
| @@ -318,6 +318,11 @@ function test_largo_transition_nav_menus() { | |||
| } | |||
|
|
|||
| function test_largo_update_prominence_term_description_single() { | |||
| $term9 = get_term_by('slug', 'term-9', 'prominence', 'ARRAY_A'); | |||
| if ( ! $term9 ) { | |||
| wp_insert_term( 'term-9', 'prominence', array( 'description' => 'Term Description 9' ) ); | |||
There was a problem hiding this comment.
We shouldn't have to create this term; it should have been created by this class' setUp method: https://github.com/rclations/Largo/blob/a773c5a2cfdbb7706c41085e8388f0d83b583e8e/tests/inc/test-update.php#L29-L31
There was a problem hiding this comment.
Previous comment might be wrong, based on #1209 (comment)
Either way, the test tests what it's supposed to test.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(still in progress)