Fix featured media display for galleries, embeds, and videos #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and fix a PHP short tag
…e context creation order, add gallery_ids context for galleries
benlk
added
type: bug
priority: high
aschweigert
reviewed
Oct 3, 2016
| @@ -863,7 +863,7 @@ function largo_update_admin_notice() { | |||
| if ( largo_need_updates() && ! ( isset( $_GET['page'] ) && $_GET['page'] == 'update-largo' ) ) { | |||
| ?> | |||
| <div class="update-nag" style="display: block;"> | |||
| <p>Largo has been updated! Please <a href="<? echo admin_url( 'index.php?page=update-largo' ); ?>">visit the update page</a> to apply a required database update.</p> | |||
| <p>Largo has been updated! Please <a href="<?php echo admin_url( 'index.php?page=update-largo' ); ?>">visit the update page</a> to apply a required database update.</p> | |||
aschweigert
reviewed
Oct 3, 2016
| @@ -1150,6 +1150,6 @@ function largo_block_theme_options_for_update() { | |||
| * @since 0.5.3 | |||
| */ | |||
| function largo_block_theme_options() { ?> | |||
| <h3>Please <a href="<? echo admin_url( 'index.php?page=update-largo' ); ?>">visit the update page</a> to apply required Largo updates before editing Theme Options.</h3> | |||
| <h3>Please <a href="<?php echo admin_url( 'index.php?page=update-largo' ); ?>">visit the update page</a> to apply required Largo updates before editing Theme Options.</h3> | |||
|
@benlk can you make those two update strings translatable? Other than that this lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In
inc/featured-media.php'slargo_get_featured_hero():embedtype of partial,partials/hero-featured-embed.php: Move Featured Media UI to Featured Image Metabox #1285 changed this tovideobut didn't create a new partial to be rendered in this space.$featured_mediain the$contextvariable, needed for embeds and videos, which was removed in Move Featured Media UI to Featured Image Metabox #1285's consolidation of the largo_get_featured_Xfunctions$contextvariable, needed for galleries, which was removed in Move Featured Media UI to Featured Image Metabox #1285's consolidation of the largo_get_featured_XfunctionsIn
partials/hero-featured-embed.php, converts a short-tag<?to the full<?phpIn
inc/update.php, converts a short-tag<?to the full<?php, because now was as good a time as any to search for other<?tags.Why
For #1322, because #1285 broke non-image featured media hero functions.