Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in largo_module_shortcode where shortcode content was not being displayed #1645

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Fix bug in largo_module_shortcode where shortcode content was not being displayed #1645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions inc/editor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,27 @@ function largo_add_mce_buttons() {

/**
* Add the module shortcode (used for pullquotes and asides within posts)
*
* This is no longer used but is included here for backwards compatibility
*
* The module insertion is handled by largo/js/tinymce/plugins/largo/tinymce.js, which now inserts <aside> tags.
*
* @since 0.3
*/
function largo_module_shortcode( $atts, $content, $code ) {
$atts = shortcode_atts( array(
'align' => 'left',
'width' => 'half',
'type' => 'aside',
), $atts );
$atts = shortcode_atts( array(
'align' => 'left',
'width' => 'half',
'type' => 'aside',
), $atts );

return sprintf( '<aside class="module %s %s %s">%s</aside>', $atts['type'], $atts['align'], $atts['width'], $atts['content'] );
return sprintf(
'<aside class="module %s %s %s">%s</aside>',
$atts['type'],
$atts['align'],
$atts['width'],
$content
);
}
add_shortcode( 'module', 'largo_module_shortcode' );

Expand Down