Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined $description in largo_opengraph() and apply WP Code Standards #1724

Merged
merged 8 commits into from
Jun 13, 2019
Merged

Fix undefined $description in largo_opengraph() and apply WP Code Standards #1724

merged 8 commits into from
Jun 13, 2019

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jun 12, 2019 •
edited
Loading

Changes

  • Fixes undefined $description in largo_opengraph() on Co-Authors Plus author archive pages. Fixes Undefined variable: $description in inc/open-graph.php on line 78 #1721.
  • Runs the largo_opengraph() function through the WordPress PHPCS code standards checker, and fixes many items.
  • Cleans up whitespace in the function and rearranges code to make it more readable.

Testing

I thought that we had automated tests for this; we don't. The barest-minimum test set has been stubbed out.

Why

For #1721.

@benlk benlk added this to the 0.6.4 milestone Jun 12, 2019
@benlk benlk mentioned this pull request Jun 13, 2019
Open
2 tasks
@benlk benlk merged commit daf3fe0 into 0.5-dev Jun 13, 2019
@benlk benlk deleted the 1721-undefined-description-open-graph branch June 13, 2019 02:17
@benlk benlk mentioned this pull request Jun 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
0.6.4
Development

Successfully merging this pull request may close these issues.

Undefined variable: $description in inc/open-graph.php on line 78
1 participant
@benlk