Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the most recent widget #444

Merged
merged 2 commits into from
Mar 25, 2015
Merged

Refactor the most recent widget #444

merged 2 commits into from
Mar 25, 2015

Conversation

wjhdev
Copy link

@wjhdev wjhdev commented Mar 24, 2015

  • Recent posts now outputs one consistent dom type (unordered list).
  • Added new image alignment setting.
  • Removed medium image option (it outputs the same as large image)
  • Commented widgets.less
  • Fixed padding issues.

 - Recent posts now outputs one consistent dom type (unordered list).
 - Added new image alignment setting.
 - Removed medium image option (it outputs the same as large image)
 - Commented widgets.less
 - Fixed padding issues.
@wjhdev
Copy link
Author

wjhdev commented Mar 24, 2015

Before we merge in, it might be worth looking at with @kaeti to see if we can make some immediate UI improvements for 0.5.

Here's what a couple configurations look like.

#1

image

#2

image

#3

image

#4

image

#5

image

@rnagle
Copy link

rnagle commented Mar 24, 2015

@willhaynes This looks good to me. I notice that there are changes to widgets.less but no corresponding css file was changed. Do we need to recompile any css for this?

@wjhdev
Copy link
Author

wjhdev commented Mar 24, 2015

Yeah. I didn't commit css to avoid merge conflicts.

@rnagle
Copy link

rnagle commented Mar 25, 2015

Cool. Feel free to commit the CSS in the future. Since presumably we're not editing those files directly, any merge conflict can be fixed with grunt less.

@rnagle rnagle merged commit bd4ff83 into develop Mar 25, 2015
@wjhdev wjhdev deleted the most-recent-refactor branch March 25, 2015 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants