Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase h5 to 1.25 * @baseFontSize for certain widgets #733

Closed
wants to merge 3 commits into from

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented May 29, 2015

Changes

For these widgets:

  • Largo sidebar featured
  • Largo featured
  • Largo recent posts
  • INN RSS

Do the following:

  • Increases the font-size of h5 elements to `1.25 * @baseFontSize
  • Increase the bottom margin on story li elements to 15px from 10px

Why

To distinguish the headlines from the body text.

For YT-34:

Text in the "Recent Posts from the New York Bureau" widget looks a little cramped. Maybe the text size for the excerpts should be slightly smaller in that section. (Looking at the widgets on the hub, maybe smaller body text overall in the widgets? Something's a little off with the padding in general.. not sure the padding is the issue though)

This may be an issue with the styling in Largo generally and we should try to address it there if this affects other sites

Before:
screen shot 2015-05-29 at 3 05 47 pm

After:
screen shot 2015-05-29 at 3 02 54 pm

@aschweigert
Copy link

this looks generally ok to me but i would probably make both the headline and p's slightly smaller

@benlk
Copy link
Collaborator Author

benlk commented Jun 5, 2015

Headline size is now 1.15 baseline, down from 1.25, and the content text is 0.9 baseline, about 14px.

@benlk
Copy link
Collaborator Author

benlk commented Jun 23, 2015

closing this in favor of #755

@benlk benlk closed this Jun 23, 2015
@rnagle rnagle deleted the YT-34-ben-recent-posts-widget branch July 13, 2015 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants