forked from argoproject/Argo
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct, non-home partial on archive pages' LMP posts. #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he partial-choosing logic. LMP now supports category archives
…rchives and appropriate partial use
(Time for this is tracked on WE-15) |
Added a couple things to this:
@benlk regarding your questions --
|
|
… the AJAX request's is_home parameter. Then move those lines down for more-readable code.
rnagle
added a commit
that referenced
this pull request
Nov 3, 2015
Use correct, non-home partial on archive pages' LMP posts.
This was referenced Dec 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
largo_load_more_posts_choose_partial()
, which returns the slug of the partial that should be combined withpartials/content-
to get the correct partial to render content withget_template_part( 'partials/content', $partial );
This function detects the following archive pages and replies with the corresponding partial slug:
largo_load_more_posts()
now useslargo_load_more_posts_choose_partial()
Why:
For #868, where the category archive page was using partials/content-archive.php but the LMP on that page was returning partials/content-home.php.
On the decision of slug to use: per this comment's research, here are the decisions and rationales:
Questions:
''
andhome
be a case that is explicitly detected?