Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Implement sniff ?] No alternative PHP open tags ? #15

Closed
1 of 2 tasks
jrfnl opened this issue Jul 11, 2016 · 1 comment
Closed
1 of 2 tasks

[Implement sniff ?] No alternative PHP open tags ? #15

jrfnl opened this issue Jul 11, 2016 · 1 comment

Comments

@jrfnl
Copy link

jrfnl commented Jul 11, 2016

Decision needed by Theme Review Board:

There is currently no rule to check for alternative PHP open tags, like ASP tags and the PHP Script tag.

There has just been a discussion upstream in WPCS that these should not be allowed in general and it is expected that the associated sniff will be merged into WPCS.

Should alternative PHP open tags be forbidden in themes as well ?

Advice: Follow WPCS's lead in this.

To do:

  • If agreed this should be a rule - add WordPress.PHP.DisallowAlternativeOpenTag sniff to the ruleset.
  • Add the rule in the Theme Review handbook to the Requirements page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants