Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should there be a check for alternative open tags ? #580

Closed
jrfnl opened this issue Jul 10, 2016 · 5 comments
Closed

Should there be a check for alternative open tags ? #580

jrfnl opened this issue Jul 10, 2016 · 5 comments
Labels
Type: Enhancement

Comments

@jrfnl
Copy link
Member

jrfnl commented Jul 10, 2016

Like ASP tags and the PHP Script tag ?

Also see: squizlabs/PHP_CodeSniffer#1063
@JDGrimes
Copy link
Contributor

Yes, I think so. Using them isn't going to be portable across sites.

jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jul 11, 2016
@jrfnl
Add sniff to disallow alternative PHP open tags.
271f546 
Fixes WordPress#580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
@jrfnl jrfnl mentioned this issue Jul 11, 2016
Merged
@jrfnl
Copy link
Member Author

jrfnl commented Jul 11, 2016

@JDGrimes Does the extra tag mean you feel this should go into the extra ruleset rather than the core ruleset ? (If so, I'll adjust the PR 😎 )

jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jul 11, 2016
@jrfnl
Add sniff to disallow alternative PHP open tags.
32699fe 
Fixes WordPress#580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
@westonruter
Copy link
Member

@jrfnl that's right. But should it not be WordPress-Core ruleset?

@jrfnl
Copy link
Member Author

jrfnl commented Jul 11, 2016

@westonruter That was what I thought as well, which is why it's there in the PR (still tweaking the PR a bit now for some outliers in the unit tests)

jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jul 11, 2016
@jrfnl
Add sniff to disallow alternative PHP open tags.
62092ee 
Fixes WordPress#580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jul 11, 2016
@jrfnl
Add sniff to disallow alternative PHP open tags.
187b770 
Fixes WordPress#580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
@JDGrimes
Copy link
Contributor

I meant to ask whether others thought whether this should be extra or not. I agree that there's really no reason that it shouldn't go in the core ruleset, so I've removed the extra tag.

jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jul 11, 2016
@jrfnl
Add sniff to disallow alternative PHP open tags.
e2b8b0c 
Fixes WordPress#580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
@jrfnl jrfnl mentioned this issue Jul 11, 2016
Closed
2 tasks
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jul 11, 2016
@jrfnl
Add sniff to disallow alternative PHP open tags.
9a5f949 
Fixes WordPress#580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jul 12, 2016
@jrfnl
Add sniff to disallow alternative PHP open tags.
d42e161 
Fixes WordPress#580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jul 13, 2016
@jrfnl
Add sniff to disallow alternative PHP open tags.
31ac198 
Fixes WordPress#580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jul 14, 2016
@jrfnl
Add sniff to disallow alternative PHP open tags.
145add2 
Fixes WordPress#580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jul 17, 2016
@jrfnl
Add sniff to disallow alternative PHP open tags.
cf1b5d6 
Fixes WordPress#580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
jrfnl added a commit to jrfnl/WordPress-Coding-Standards that referenced this issue Jul 21, 2016
@jrfnl
Add sniff to disallow alternative PHP open tags.
961d13c 
Fixes WordPress#580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
grappler referenced this issue in WPTT/WPThemeReview Sep 25, 2016
@jrfnl @grappler
Add sniff to disallow alternative PHP open tags.
0d94582 
Fixes #580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
JDGrimes pushed a commit that referenced this issue Oct 8, 2016
@jrfnl @JDGrimes
Add sniff to disallow alternative PHP open tags.
3e15b81 
Fixes #580

This should be removed again if the upstream issue squizlabs/PHP_CodeSniffer#1063 would get traction and the associated PR would be merged *and* the minimum PHPCS version for WPCS would become higher than the version in which the PR is merged ;-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@westonruter @jrfnl @JDGrimes