Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS 2.9.0: Update sniffs to use the new PHP_CodeSniffer_Tokens::$textStringTokens token array. #138

Merged

Conversation

jrfnl
Copy link

@jrfnl jrfnl commented May 4, 2017

⚠️ This PR should not be merged until WPCS has been merged back into the TRTCS as the WPCS minimum requirement of PHPCS 2.9.0 has only recently been changed in WPCS (as PHPCS 2.9.0 has only just been released).

Rebased after the merge of #145. Amended the original commit with a minor change for PHPCS 3.x compatibility. Merging should now be fine.

Fixes #128

Copy link
Member

@grappler grappler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@jrfnl jrfnl merged commit 9a1d6d3 into feature/theme-review-sniffs May 31, 2018
@jrfnl jrfnl deleted the feature/issue-128-use-new-token-array branch May 31, 2018 11:01
@jrfnl jrfnl added this to the 0.1.0 milestone Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants