Add deprecated parameter values rule in the ruleset #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 18, 2019
jrfnl
reviewed
May 19, 2019
There was a problem hiding this comment.
Reviewed. I'm fine with this, but I suggested it, so I may be biased ;-)
Other that that, I think it would make sense to add the sniff to the list of other sniffs related to deprecated features instead of at the end of the ruleset: https://github.com/WPTRT/WPThemeReview/blob/31674d4c6fb1fb315ad7f1ead3a358fad131517b/WPThemeReview/ruleset.xml#L120
jrfnl
approved these changes
May 20, 2019
delete-merged-branch
bot
deleted the
feature/add-deprecated-parameter-values-sniff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issue #171 added deprecated parameter values rule in the ruleset.