Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install phpcsutils for travis tests when testing with phpcs:dev-master #256

Closed

Conversation

pattonwebz
Copy link
Member

This is an attempt to fix some of the travis testing when using dev-master branch on phpcs

@pattonwebz pattonwebz force-pushed the william/tweak/fix-travis-for-lastest-phpcs branch from 7664b8c to 9ade6bb Compare July 29, 2020 10:16
Copy link

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are in WPCS, not PHPCS ;-)

@pattonwebz
Copy link
Member Author

🤦 I blame @dingo-d lol. Thanks @jrfnl for the tip, I think I'll probably just change max version temporary like you suggested in the other thread though. That's the simplest solution.

@pattonwebz pattonwebz force-pushed the william/tweak/fix-travis-for-lastest-phpcs branch from b32cdce to a6c6c9b Compare July 29, 2020 12:13
@jrfnl
Copy link

jrfnl commented Feb 19, 2021

Closing as superseded by the now merged PR #261.

Until there is a RC for WPCS 3.0.0, let's not worry too much about the upstream changes.

@jrfnl jrfnl closed this Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants