Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to utilise GH actions for running checks instead of travis #261

Merged
merged 39 commits into from Feb 19, 2021

Commits on Nov 28, 2020

  1. Add the sniff stage

    dingo-d committed Nov 28, 2020
    Copy the full SHA
    75e4059 View commit details
    Browse the repository at this point in the history
  2. Remove travis file

    No need to clutter checks
    dingo-d committed Nov 28, 2020
    Copy the full SHA
    dcfe1ad View commit details
    Browse the repository at this point in the history
  3. Setup xml lint

    dingo-d committed Nov 28, 2020
    Copy the full SHA
    dab3683 View commit details
    Browse the repository at this point in the history
  4. Remove XMLLINT_INDENT export

    dingo-d committed Nov 28, 2020
    Copy the full SHA
    da02fd2 View commit details
    Browse the repository at this point in the history
  5. Add empty test.yaml file

    dingo-d committed Nov 28, 2020
    Copy the full SHA
    6f0d414 View commit details
    Browse the repository at this point in the history
  6. Fix the diff?

    dingo-d committed Nov 28, 2020
    Copy the full SHA
    4d595d3 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2020

  1. Trying to fix the diff

    dingo-d committed Nov 29, 2020
    Copy the full SHA
    6eaefd0 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2020

  1. Try to run on xenial

    dingo-d committed Dec 6, 2020
    Copy the full SHA
    8bfb9df View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2020

  1. Copy the full SHA
    9d76af2 View commit details
    Browse the repository at this point in the history
  2. Trying to add test stage

    dingo-d committed Dec 12, 2020
    Copy the full SHA
    90274d3 View commit details
    Browse the repository at this point in the history
  3. Try to exclude certain versions

    Only allow master phpcs and develop wpcs on one PHP version, and that should be allowed to fail
    dingo-d committed Dec 12, 2020
    Copy the full SHA
    e17ba7f View commit details
    Browse the repository at this point in the history
  4. Refine exclusions

    We only need master - master and lowest - lowest for every PHP version, not all 4 possible combinations.
    dingo-d committed Dec 12, 2020
    Copy the full SHA
    ccac4f8 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    e8a8e9d View commit details
    Browse the repository at this point in the history
  6. Adding php 5.4 and 5.5

    dingo-d committed Dec 12, 2020
    Copy the full SHA
    dfc2177 View commit details
    Browse the repository at this point in the history
  7. Fix typo

    dingo-d committed Dec 12, 2020
    Copy the full SHA
    0874eb7 View commit details
    Browse the repository at this point in the history
  8. Add nightly to build

    dingo-d committed Dec 12, 2020
    Copy the full SHA
    024c796 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2020

  1. Fix the sniff workflow

    dingo-d committed Dec 13, 2020
    Copy the full SHA
    699bbd2 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2020

  1. Update suggestions for dealerdirect plugin

    So that it works with the composer v2
    dingo-d committed Dec 20, 2020
    Copy the full SHA
    22215e1 View commit details
    Browse the repository at this point in the history
  2. Remove travis reference

    dingo-d committed Dec 20, 2020
    Copy the full SHA
    935a581 View commit details
    Browse the repository at this point in the history
  3. Fix the minor grammar issues in the Contributing file

    Also change the theme review team repo to correct repo name. It's themes team now.
    dingo-d committed Dec 20, 2020
    Copy the full SHA
    f38c3ee View commit details
    Browse the repository at this point in the history
  4. Fix the sniff stage accordding to the PR suggestions

    Also, some ideas from PHPCompatibility PR PHPCompatibility/PHPCompatibility#1260 were implemented as well (composer dependencies and xml violations).
    dingo-d committed Dec 20, 2020
    Copy the full SHA
    7e52ae9 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    ee596d4 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    12aa082 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    817d38d View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    e4b2a58 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    9c0697e View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    0797dd1 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. GH Actions: remove the ignores for markdown files

    ... as it would prevent PRs with only markdown changes from being merged due to required statuses.
    jrfnl committed Feb 19, 2021
    Copy the full SHA
    d526f26 View commit details
    Browse the repository at this point in the history
  2. GH Actions: allow for manually triggering a workflow

    Triggering a workflow for a branch manually is not supported by default in GH Actions, but has to be explicitly allowed.
    
    Ref: https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/
    jrfnl committed Feb 19, 2021
    Copy the full SHA
    e87f9e9 View commit details
    Browse the repository at this point in the history
  3. GH Actions: remove GH token from setup PHP step

    ... as it shouldn't be needed.
    jrfnl committed Feb 19, 2021
    Copy the full SHA
    e7e9def View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    40d2f74 View commit details
    Browse the repository at this point in the history
  5. GH Actions: add lint workflow

    As things were, the code was only ever linted against PHP 7.4, while in the original Travis workflow, the code was linted against every single supported PHP version.
    
    This adds a hybrid workflow in which the code is linted against the high/low of each PHP major within the range of supported PHP versions.
    jrfnl committed Feb 19, 2021
    Copy the full SHA
    c7b8670 View commit details
    Browse the repository at this point in the history
  6. GH Actions: use Parallel-Lint for PHP linting

    Not a necessity, but allows for:
    1. Faster linting due to the parallel option.
    2. The ability to display linting errors in the PR via the cs2pr tooling.
    jrfnl committed Feb 19, 2021
    Copy the full SHA
    70f794f View commit details
    Browse the repository at this point in the history
  7. GH Actions: fix up the matrix

    The minimum supported PHPCS version according to the `composer.json` file, is `3.3.1`, so that should be the minimum version to test against.
    Similarly, the minimum supported WPCS version according to the `composer.json` file is `2.2.0`.
    
    For PHP 7.4 and 8.0, the builds have to be specified explicitly as PHP 7.4 only has PHPCS runtime support as of PHPCS 3.5.0 and PHP 8.0, as of PHPCS 3.5.7.
    
    As the matrix builds only test high PHPCS with high WPCS and low PHPCS with low WPCS, for PHP 7.2, in the Travis config, explicit builds were specified to reverse that combination, i.e. high PHPCS with low WPCS and low PHPCS with high WPCS.
    This has now been implemented here as well.
    
    Includes adding some inline documentation to the matrix.
    
    Note: I've not added a build against PHP 8.1/nightly as the PHPUnit version we are forced to use via PHPCS (PHPUnit 7.x) is not compatible with PHP 8.1, so the build wouldn't pass no matter what.
    jrfnl committed Feb 19, 2021
    Copy the full SHA
    8ad0437 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    4177063 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    924643e View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    032fe1b View commit details
    Browse the repository at this point in the history
  11. Readme: fix up the badges

    ... based on latest example code generate on the Actions page.
    jrfnl committed Feb 19, 2021
    Copy the full SHA
    abd53e0 View commit details
    Browse the repository at this point in the history
  12. Copy the full SHA
    6546201 View commit details
    Browse the repository at this point in the history