Check for Hardcoded Urls #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <!-- No PHP short open tags allowed. --> | ||
| <!-- Covers: https://github.com/Otto42/theme-check/blob/master/checks/phpshort.php --> | ||
| <rule ref="Generic.PHP.DisallowShortOpenTag" /> | ||
|
|
||
|
|
||
| <rule ref="WordPress-Theme" /> |
There was a problem hiding this comment.
Could you leave this out for the moment as it will make it easier to merge in the future as it may be added in another PR before hand?
There was a problem hiding this comment.
jrf walked me through this and included it?
There was a problem hiding this comment.
That's fine. Listen to @jrfnl. She's the Boss! :P
4 tasks
grappler
force-pushed
the
feature/theme-review-sniffs
branch
2 times, most recently
from
563cd1d
to
6671823
Compare
added 2 commits
October 14, 2016 11:21
Added exemption for theme and author urls by using the WordPress_AbstractThemeSniff class.
72 tasks
|
PR is not ready to be merged as we wish to add theme and author URLS to the whitelist. related #101 |
|
Closing for now, we may revisit this in another form in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request looks at detecting hard coded urls in theme files.
close #14