Plugin Territory Functions #81
Conversation
| */ | ||
| public function getGroups() { | ||
| return array( | ||
| 'filefunctions' => array( |
There was a problem hiding this comment.
I would name this plugin-territory
grappler
force-pushed
the
feature/theme-review-sniffs
branch
2 times, most recently
from
563cd1d
to
6671823
Compare
| * @package PHP_CodeSniffer | ||
| * @author khacoder | ||
| */ | ||
| class WordPress_Sniffs_Theme_PluginTerritoryFunctionsSniff extends WordPress_Sniffs_Functions_FunctionRestrictionsSniff { |
There was a problem hiding this comment.
This should extend the abstract function restrictions sniff
| * @category PHP | ||
| * @package PHP_CodeSniffer | ||
| * @link https://make.wordpress.org/core/handbook/best-practices/coding-standards/ | ||
| */ |
There was a problem hiding this comment.
Same as before: please update and the same goes for the other docblocks.
Initial commit. Issue #73
|
@jrfnl The checks are passing on this too. |
| /** | ||
| * Restricts the use of various functions that are plugin territory. | ||
| * | ||
| * @link https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#regular-expressions |
There was a problem hiding this comment.
Please update the link to a relevant URL in the theme review handbook
| return array( | ||
| 'plugin-territory' => array( | ||
| 'type' => 'error', | ||
| 'message' => '%s() is not allowed because it is a plugin territory function.', |
There was a problem hiding this comment.
Just wondering if this would read better - feel free to disregard if you don't agree:
Function %s() is not allowed because it is plugin territory
| register_taxonomy_for_object_type( 'category', 'page' ); | ||
| flush_rewrite_rules( false ); | ||
|
|
||
| xyz_add_shortcode(); // OK. |
There was a problem hiding this comment.
Maybe add these too ?
My_Plugin_Class::add_shortcode();
$my_plugin_object->add_shortcode();
|
Requested changes added. |
| * @package PHP_CodeSniffer | ||
| * @author khacoder | ||
| * @package WPCS\WordPressCodingStandards | ||
| * @since 0.10.0 |
There was a problem hiding this comment.
arg, in my copy and paste I missed that. Has been fixed.
Initial PR
Issue #73