Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved Issue #16 #21

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Resolved Issue #16 #21

merged 1 commit into from
Jul 11, 2023

Conversation

camaechi
Copy link

@camaechi camaechi commented Jun 20, 2023 •
edited
Loading

One hour in real life equals 12 hours of daytime in the game, and the next one hour in real life equals 12 hours of nighttime in the game.

@camaechi camaechi self-assigned this Jun 20, 2023
@camaechi camaechi changed the title Issue #16 Resolved Issue #16 Jun 20, 2023
TonePoems
TonePoems reviewed Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@TonePoems TonePoems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you still need tests. My testing suite may be a blocker to you since they have not been written yet.

@camaechi camaechi merged commit 5151507 into master Jul 11, 2023
@camaechi camaechi linked an issue Jul 17, 2023 that may be closed by this pull request
Extend Daylight and Night Time Duration #16
Closed
This was referenced Jul 21, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonePoems TonePoems TonePoems left review comments

@dburd08 dburd08 Awaiting requested review from dburd08

Assignees

@camaechi camaechi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend Daylight and Night Time Duration
2 participants
@camaechi @TonePoems