Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re-Do) Resolved issue #16 #50

Merged
merged 1 commit into from
Jul 22, 2023
Merged

(Re-Do) Resolved issue #16 #50

merged 1 commit into from
Jul 22, 2023

Conversation

camaechi
Copy link

Pull request #38 reverted the changes made by pull request #21 because it was merged without being approved. This pull request adds the changes that #21 made again and now needs to be approved.

Copy link
Collaborator

@TonePoems TonePoems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have the testing proof as we discussed the other night I am happy with this. As Joshi described it will be a separate PR anyways so this one looks good

Copy link
Collaborator

@dburd08 dburd08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes

@camaechi camaechi merged commit c387942 into master Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing: Extend Daylight and Night Time Duration Extend Daylight and Night Time Duration
3 participants