Resolved issue #4 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonePoems
requested changes
Jun 21, 2023
| if (!g->typing) { | ||
| float m = dt * 1.0; | ||
| g->ortho = glfwGetKey(g->window, CRAFT_KEY_ORTHO) ? 64 : 0; | ||
| g->fov = glfwGetKey(g->window, CRAFT_KEY_ZOOM) ? 15 : 65; | ||
| if (glfwGetKey(g->window, CRAFT_KEY_FORWARD)) sz--; | ||
| if (glfwGetKey(g->window, CRAFT_KEY_BACKWARD)) sz++; | ||
| if (glfwGetKey(g->window, CRAFT_KEY_FORWARD)) { | ||
| if(glfwGetKey(g->window, CRAFT_KEY_RUN)) isRunning = 1; |
There was a problem hiding this comment.
I would suggest including this under the existing CRAFT_KEY_FORWARD if statement as it is duplicated code
src/main.c
Outdated
| @@ -2439,6 +2444,7 @@ void handle_movement(double dt) { | |||
| } | |||
| } | |||
| float speed = g->flying ? 20 : 5; | |||
| if(isRunning) speed*=4; | |||
There was a problem hiding this comment.
I thought a multiplier of 1.5 felt better when I tested it. Reminded me of minecrafts sprint; *4 seems like with speed boosts. But of course that is just preference
|
Oh this should also be added to the readme section on controls |
added 2 commits
June 20, 2023 22:11
Requested changes have been made.
The controls section in README.md has been updated.
|
capturing comments from team discord: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CTRL + W to run faster