Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Re-Do) Resolved issue #4 #56

Merged
merged 1 commit into from
Jul 25, 2023
Merged

(Re-Do) Resolved issue #4 #56

merged 1 commit into from
Jul 25, 2023

Conversation

camaechi
Copy link

Pull request #51 reverted some of the changes made by pull request #22 because it was merged without being approved. This pull request adds the remaining changes that #22 made again and now needs to be approved.

@camaechi camaechi self-assigned this Jul 22, 2023
Copy link
Collaborator

@TonePoems TonePoems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the full PR? Doesnt look like the whole feature unless it got lost in the shuffle somewhere.

@camaechi
Copy link
Author

For some reason, the revert pr removed only a partial amount of the code, I don’t know why it did that. So since some of the code is still in the master branch, this is all that needs to be merged.

@camaechi camaechi requested a review from TonePoems July 24, 2023 04:41
Copy link
Collaborator

@TonePoems TonePoems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question answered, comfortable with the changes

Copy link
Collaborator

@dburd08 dburd08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@camaechi camaechi merged commit 27ef56a into master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing: Sprinting mode for walking issue #4 Sprinting mode for walking
3 participants