Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve issue #2 #30

Merged
merged 1 commit into from
Jul 19, 2023
Merged

resolve issue #2 #30

merged 1 commit into from
Jul 19, 2023

Conversation

dburd08
Copy link
Collaborator

@dburd08 dburd08 commented Jul 16, 2023

Deeper mining world, added a layer of cobblestone below the existing sand and grass terrains

@dburd08 dburd08 self-assigned this Jul 16, 2023
Copy link

@camaechi camaechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cobblestone looks great. The code looks good, easy to understand and is well documented.

@TonePoems
Copy link
Collaborator

No sure how many commits you have on your other PRs, but just want to remind you about the commit requirement for class. Other than that great code explanation as always. I assume there is a testing PR for this so I will approve the code change

Copy link
Collaborator

@TonePoems TonePoems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my above comment

@dburd08 dburd08 merged commit e2aedda into master Jul 19, 2023
@dburd08 dburd08 linked an issue Jul 19, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deeper mining world
3 participants