fix: computation of slides per view when swiper is full width #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-hv
force-pushed
the
fix-full-width-swiper
branch
2 times, most recently
from
801f63a
to
11c29ec
Compare
simon-hv
force-pushed
the
fix-full-width-swiper
branch
from
7a28056
to
2c6cff6
Compare
theo-mesnil
approved these changes
Apr 24, 2024
simon-hv
force-pushed
the
fix-full-width-swiper
branch
from
2c6cff6
to
9a24a71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When swiper has "fullWidth" prop to true, we display 2 additional items on resolutions >1920px.
But these 2 additional items displayed had the 'aria-hidden' property set to true, which prevented us from interacting with these items (such as clicking on a link).