Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: typescript [OLD] #485

Closed
wants to merge 19 commits into from
Closed

feat: typescript [OLD] #485

wants to merge 19 commits into from

Conversation

anucreative
Copy link
Contributor

No description provided.

@remorses
Copy link

Does this means this library will have types by default?

The only thing that prevents me from using these components is typescript support, i am so happy that you will add them directly in the packages

Awesome work!

@trustin
Copy link

trustin commented Apr 12, 2020

Thanks a lot for working on this pull request and the project itself. Could you let us know the status of this pull request? I'm curious about when this will land or what the plan around this is. Given the number of components to migrate, it may be better migrating incrementally.

@anucreative
Copy link
Contributor Author

Hi @remorses, @trustin 👋

Yes, the goal is to move everything to Typescript but it may take us a while. And, yes, we'll probably do it incrementally. This PR was the result of a few hours work to see how feasible it was. We'll keep you up-to-date on progress but I expect the next opportunity we'll have to work on this (Typescript migration) will be next month.

@theo-mesnil
Copy link
Contributor

theo-mesnil commented Aug 18, 2020

Old PR, typescript is not planned for the moment :)

@mleralec mleralec changed the title feat: typescript feat: typescript [OLD] Jul 8, 2021
@theo-mesnil
Copy link
Contributor

#854

@trustin
Copy link

trustin commented Aug 3, 2021

Excellent work, folks! ❤️

@theo-mesnil theo-mesnil deleted the feat-typescript branch October 13, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants