-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Account Page #87
New Account Page #87
Conversation
…ality to submit button
47b5ff9
to
2ccbdfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I rebased the branch and added type="email"
to the email field.
Oh cool, does that alter the keyboard that gets pulled up on mobile? |
I think it does. It'll also validate with a regex that ensures that the email is in the correct format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. Looking forward to the backend implementation
@Braden50 wait doesn't it already work on the backend? |
Yeah my bad I must have been confused with the sign in for some reason. |
Summary
Added a page for users to create a new account. It asks for a username, email, and password, all of which are required. When they user clicks Submit, they are automatically signed in and transferred to the profile page.
Testing
Open up the app and navigate to
/new-account
. Make sure it requires all three entries to be filled before submission, and verify the user is signed in properly.Fixes #65