Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Account Page #87

Merged
merged 6 commits into from
Apr 23, 2021
Merged

New Account Page #87

merged 6 commits into from
Apr 23, 2021

Conversation

gwholland3
Copy link
Collaborator

Summary

Added a page for users to create a new account. It asks for a username, email, and password, all of which are required. When they user clicks Submit, they are automatically signed in and transferred to the profile page.

Testing

Open up the app and navigate to /new-account. Make sure it requires all three entries to be filled before submission, and verify the user is signed in properly.

Fixes #65

Copy link
Owner

@Waidhoferj Waidhoferj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I rebased the branch and added type="email" to the email field.

@gwholland3
Copy link
Collaborator Author

Oh cool, does that alter the keyboard that gets pulled up on mobile?

@Waidhoferj
Copy link
Owner

I think it does. It'll also validate with a regex that ensures that the email is in the correct format.

Copy link
Collaborator

@Braden50 Braden50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Looking forward to the backend implementation

@gwholland3
Copy link
Collaborator Author

All looks good. Looking forward to the backend implementation

@Braden50 wait doesn't it already work on the backend?

@Braden50
Copy link
Collaborator

All looks good. Looking forward to the backend implementation

@Braden50 wait doesn't it already work on the backend?

Yeah my bad I must have been confused with the sign in for some reason.

@gwholland3 gwholland3 merged commit e7e80ad into main Apr 23, 2021
@gwholland3 gwholland3 deleted the gwholland3/new-account-page branch April 23, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create New Account Page
3 participants