This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
feat: Self-Hosted GoTrue infrastructure #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryET
added
enhancement
|
Nitpick: the PR is too large and should have been split up into multiple PRs |
arein
reviewed
Jul 11, 2022
| region = "eu-central-1" | ||
| azs = ["eu-central-1a", "eu-central-1b", "eu-central-1c"] | ||
| fqdn = "login.walletconnect.com" | ||
| fqdn_subdomain = "dev" |
There was a problem hiding this comment.
curious: how do we do this in prod where we don't want to have prod.login.walletconnect.com but simply login.walletconnect.com?
There was a problem hiding this comment.
fqdn_subdomain is nullable, on line 180 in ecs/gotrue.tf we do a check and assign to root if null
arein
reviewed
Jul 13, 2022
Comment on lines
+72
to
+73
| cpu = var.cpu - 128, | ||
| memory = var.cpu - 256, |
There was a problem hiding this comment.
Those are the values that AWS say that the OTEL Collector need, so I minus them so that everything adds up to the fully CPU amount
arein
approved these changes
Jul 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changes Tested
terraform -chdir=terraform apply -var-file="vars/dev.tfvars"locally