-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Self-Hosted GoTrue infrastructure #12
Conversation
Nitpick: the PR is too large and should have been split up into multiple PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff! a few comments
region = "eu-central-1" | ||
azs = ["eu-central-1a", "eu-central-1b", "eu-central-1c"] | ||
fqdn = "login.walletconnect.com" | ||
fqdn_subdomain = "dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious: how do we do this in prod where we don't want to have prod.login.walletconnect.com
but simply login.walletconnect.com
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fqdn_subdomain is nullable, on line 180 in ecs/gotrue.tf
we do a check and assign to root if null
cpu = var.cpu - 128, | ||
memory = var.cpu - 256, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why - 128
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are the values that AWS say that the OTEL Collector need, so I minus them so that everything adds up to the fully CPU amount
Changes
Changes Tested
terraform -chdir=terraform apply -var-file="vars/dev.tfvars"
locally