fix: use axum-client-ip to get the real client IP
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekbrother
force-pushed
the
max/fix/geoip_grey_ip_errors
branch
from
c6c822a
to
a4ac7b8
Compare
|
Nice vendor agnostic solution! |
arein
approved these changes
Oct 6, 2023
chris13524
requested changes
Oct 7, 2023
geekbrother
force-pushed
the
max/fix/geoip_grey_ip_errors
branch
from
a4ac7b8
to
e7d73d8
Compare
chris13524
approved these changes
Oct 8, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds using of
axum-client-ipto get a real client IP which is included in theX-Forwardedby callingSecureClientIp. The AWS ELB uses X-Forwarded-for and SecureClientIp sourced it for a real IP.Following changes are made:
axum-client-ipis added to theCargo.tomlas a dependency. We already have it as a relative dependency in theCargo.lockso it will not add additional dependency weight.ConnectInforeplaced withSecureClientIp.Resolves #225
How Has This Been Tested?
Successfully built and run with
analyticsfeature enabled.Due Diligence