Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding jwt verification to the apns and fcm update handler #261

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix: adding jwt verification to the apns and fcm update handler #261

merged 3 commits into from
Oct 25, 2023

Conversation

geekbrother
Copy link
Contributor

@geekbrother geekbrother commented Oct 21, 2023 •
edited
Loading

Description

This PR adds missing JWT verification to the:

  • update apns handler,
  • update fcm handler.

Resolves #262

How Has This Been Tested?

Functional tests for valid apns and fcm update fails without providing jwt.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother added the area-auth Authentication label Oct 21, 2023
@geekbrother geekbrother self-assigned this Oct 21, 2023
@arein arein added the accepted The issue has been accepted into the project label Oct 21, 2023
@geekbrother geekbrother force-pushed the max/fix/add_jwt_for_update_apns branch 2 times, most recently from a39eacd to 92773ed Compare October 23, 2023 07:43
@geekbrother geekbrother marked this pull request as ready for review October 23, 2023 07:51
@arein
Copy link
Member

arein commented Oct 23, 2023

Looks like a breaking change? How many users will we break

@geekbrother
Copy link
Contributor Author

geekbrother commented Oct 23, 2023 •
edited
Loading

Looks like a breaking change? How many users will we break

Is it used only by our cloud app? If so, we already have the JWT header for these requests in our cloud app here and here. That's why my assumption that the JWT check was just forgotten.

@chris13524 chris13524 mentioned this pull request Oct 23, 2023
Merged
3 tasks
@geekbrother geekbrother changed the title fix: adding jwt verification to the apns update handler fix: adding jwt verification to the apns and fcm update handler Oct 23, 2023
@geekbrother geekbrother force-pushed the max/fix/add_jwt_for_update_apns branch from 92773ed to e81ee4c Compare October 25, 2023 10:44
@geekbrother geekbrother merged commit 2c454eb into main Oct 25, 2023
4 checks passed
@geekbrother geekbrother deleted the max/fix/add_jwt_for_update_apns branch October 25, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arein arein arein approved these changes

@chris13524 chris13524 chris13524 approved these changes

Assignees

@geekbrother geekbrother

Labels
accepted The issue has been accepted into the project area-auth Authentication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: missing jwt validation in apns and fcm update handler
3 participants
@geekbrother @arein @chris13524