feat(decrypted_notify): update message payload and pass raw message #281
Conversation
geekbrother
changed the base branch from
main
to
feat/decrypted_notifs/add_always_raw_to_register
geekbrother
force-pushed
the
feat/decrypted_notifs/add_always_raw_to_register
branch
from
fa9b0b9
to
8269b2c
Compare
geekbrother
force-pushed
the
feat/decrypted_notifs/update_message_payload_and_pass_raw
branch
2 times, most recently
from
1742104
to
4a6f0c3
Compare
geekbrother
force-pushed
the
feat/decrypted_notifs/add_always_raw_to_register
branch
from
8269b2c
to
ed6a83e
Compare
geekbrother
force-pushed
the
feat/decrypted_notifs/update_message_payload_and_pass_raw
branch
2 times, most recently
from
bca5560
to
3a9a2a0
Compare
There was a problem hiding this comment.
LGTM, but please do not merge until https://github.com/WalletConnect/rs-relay/pull/1285 is merged so we can ensure there are no backwards incompatibilities.
geekbrother
force-pushed
the
feat/decrypted_notifs/update_message_payload_and_pass_raw
branch
from
3a9a2a0
to
28f331e
Compare
| @@ -175,18 +178,52 @@ pub async fn handler_internal( | |||
| ) | |||
| })?; | |||
|
|
|||
| let cloned_body = body.clone(); | |||
| let push_message = if client.always_raw { | |||
There was a problem hiding this comment.
Probably this condition or our spec description should be changed because in our spec we require the tag to be presented as well if always_raw == false to filter by tag and send clear text notification for some of the tags. I think we should fix this in a spec and do tag filtering when the always_raw == true. cc @chris13524
There was a problem hiding this comment.
When set to
false, cleartext notifications will be sent for certain messages based ontag
This filtering is performed in the relay, and was already implemented. So I don't think anything needs to be done here.
Cargo.toml
Outdated
| @@ -66,7 +66,7 @@ fcm = "0.9" | |||
| ed25519-dalek = "2.0.0-rc.2" | |||
|
|
|||
| # JWT Authentication | |||
| relay_rpc = { git = "https://github.com/WalletConnect/WalletConnectRust.git", rev = "ced99e7"} | |||
| relay_rpc = { git = "https://github.com/WalletConnect/WalletConnectRust.git", rev = "4ee9007"} | |||
There was a problem hiding this comment.
Must we use hashes on repos we control?
It would be much better to make a release and use the tag in our dependencies.
geekbrother
force-pushed
the
feat/decrypted_notifs/update_message_payload_and_pass_raw
branch
from
c22be2a
to
d79dbf3
Compare
geekbrother
deleted the
feat/decrypted_notifs/update_message_payload_and_pass_raw
branch
Description
This PR adds
topic,tagandmessagefields for the send notification request payload to follow the specs for the decrypted notifications.The handler modification checks if the client was registered (have)
always_rawastrueand then handles the message as an encrypted with the payload from themessagefield. Otherwise, handle the payload as usual to support backward compatibility.Related to #278
How Has This Been Tested?
always_raw = trueand push message with the new required fields are tested by the new test_push_always_raw test.Review stack 🏗️
1 - Adding always_raw for the client registration #279
2 - Update message payload and pass raw message #281 <-
Due Diligence