Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use new fields exclusively #283

Merged
merged 3 commits into from
Nov 17, 2023
Merged

fix: use new fields exclusively #283

merged 3 commits into from
Nov 17, 2023

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Nov 17, 2023 •
edited
Loading

Description

Improves on #281

  • Adds missing tag to custom data
  • When always_raw is enabled, use the new fields exclusively for idempotency
    • Required updating to latest version of WalletConnectRust library, which had minor impacts on JWT parsing code
  • Makes new and old fields both optional, with the usage determined by the client's always_raw preference.

How Has This Been Tested?

Automated tests

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Nov 17, 2023
@arein arein added the accepted The issue has been accepted into the project label Nov 17, 2023
@chris13524 chris13524 changed the title Fix/use new fields exclusive fix: use new fields exclusively Nov 17, 2023
@chris13524 chris13524 changed the base branch from feat/decrypted_notifs/add_always_raw_to_register to feat/decrypted_notifs/update_message_payload_and_pass_raw November 17, 2023 15:12
@chris13524 chris13524 merged commit e8798ac into feat/decrypted_notifs/update_message_payload_and_pass_raw Nov 17, 2023
6 checks passed
@chris13524 chris13524 deleted the fix/use-new-fields-exclusive branch November 17, 2023 16:11
geekbrother pushed a commit that referenced this pull request Nov 21, 2023
@chris13524 @geekbrother
fix: use new fields exclusively (#283)
4b37a80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekbrother geekbrother geekbrother approved these changes

Assignees

@chris13524 chris13524

Labels
accepted The issue has been accepted into the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chris13524 @geekbrother @arein