Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rate limit 10 req/min #331

Merged
merged 2 commits into from
May 17, 2024
Merged

fix: rate limit 10 req/min #331

merged 2 commits into from
May 17, 2024

Conversation

chris13524
Copy link
Member

Description

Slack conversation

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this May 17, 2024
@arein arein added the accepted The issue has been accepted into the project label May 17, 2024
@@ -11,8 +11,6 @@ use std::{net::IpAddr, sync::Arc};
use tokio::time::Duration;
use tracing::error;

pub const MAX_REQUESTS_PER_SEC: u32 = 10;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't rename to PER_MIN and removed instead since the desire to change rate limit is more than just changing this constant; we may change the window too

Copy link
Contributor

@geekbrother geekbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@chris13524 chris13524 merged commit 1c3a860 into main May 17, 2024
6 checks passed
@chris13524 chris13524 deleted the fix/rate-limit-10-per-min branch May 17, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The issue has been accepted into the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants