Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: forward errors to sentry #407

Merged
merged 4 commits into from
Jan 16, 2024
Merged

chore: forward errors to sentry #407

merged 4 commits into from
Jan 16, 2024

Conversation

devceline
Copy link
Collaborator

@devceline devceline commented Jan 16, 2024

Description

  • add logError utility
  • convert all console.error calls to logError (bar firebase-messager as we can't use sentry there)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Fixes/Resolves (Optional)

Please list any issues that are fixed by this PR in the format #<issue number>. If it fixes multiple issues, please put each issue in a separate line. If this Pull Request does not fix any issues, please delete this section.

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-web3inbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 5:56pm

Copy link
Member

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 minor corrections/cleanup

tsconfig.json Outdated Show resolved Hide resolved
src/utils/hooks/useNotifyProjects.ts Outdated Show resolved Hide resolved
src/utils/projects.ts Outdated Show resolved Hide resolved
@devceline devceline merged commit 6f3eb1d into main Jan 16, 2024
3 checks passed
@devceline devceline deleted the fix/error-handling-report branch January 16, 2024 17:59
enesozturk pushed a commit that referenced this pull request Jan 18, 2024
* chore: forward errors to sentry

* chore: run prettier

* chore: fix tsconfig

* chore: remove extra logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants