New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reset sa enabled networks #2104
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
await walletModalPage.togglePreferredAccountType() | ||
await walletModalPage.disconnect() | ||
await walletModalPage.page.waitForTimeout(2500) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this absolutely required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was preventing the magic disconnect promise from resolving, but shoould work without it.
will push fix in a diff pr if possible
await walletModalPage.disconnect() | ||
await walletModalPage.page.waitForTimeout(2500) | ||
|
||
await walletModalPage.emailFlow('web3modal-smart-account@mailsac.com', context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract to const
Breaking Changes
N/A
Changes
disconnect
not being awaited. Issue where a SA user could disconnect, connect with a non-enabled account and SA flow would be prompted due to network being enabled, ending in error.