-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reset sa enabled networks #2104
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2adf206
chore: add NetworkController missing tests
tomiir dae04ab
fix: ethers issue with disconnect. Add switch network to non auth eoa…
tomiir 6df775c
chore: add disconnect email ui test
tomiir 16b009c
fix: remove extra emit in ethers
tomiir 8f395eb
fix: test result route
tomiir 8b2826e
fix: increse timeout
tomiir File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 17 additions & 45 deletions
62
apps/laboratory/tests/shared/fixtures/w3m-smart-account-fixture.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,8 @@ import { testModalSmartAccount } from './shared/fixtures/w3m-smart-account-fixtu | |
import type { ModalWalletPage } from './shared/pages/ModalWalletPage' | ||
import type { ModalWalletValidator } from './shared/validators/ModalWalletValidator' | ||
|
||
const NOT_ENABLED_SMART_ACCOUNT_INDEX = 10 | ||
|
||
testModalSmartAccount.beforeEach(async ({ modalValidator }) => { | ||
await modalValidator.expectConnected() | ||
}) | ||
|
@@ -45,8 +47,26 @@ testModalSmartAccount( | |
const walletModalValidator = modalValidator as ModalWalletValidator | ||
|
||
await walletModalPage.togglePreferredAccountType() | ||
await walletModalPage.switchNetwork('Polygon') | ||
await walletModalPage.switchNetwork('Avalanche') | ||
await walletModalPage.openSettings() | ||
await walletModalValidator.expectEoaAddress(testInfo.parallelIndex) | ||
} | ||
) | ||
|
||
testModalSmartAccount( | ||
'it should use an eoa when disconnecting and connecting to a not enabled address', | ||
async ({ modalPage, modalValidator, context }) => { | ||
const walletModalPage = modalPage as ModalWalletPage | ||
const walletModalValidator = modalValidator as ModalWalletValidator | ||
|
||
await walletModalPage.togglePreferredAccountType() | ||
await walletModalPage.disconnect() | ||
await walletModalPage.page.waitForTimeout(2500) | ||
|
||
await walletModalPage.emailFlow('web3modal-smart-account@mailsac.com', context) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Extract to const |
||
await walletModalPage.switchNetwork('Sepolia') | ||
await walletModalPage.openSettings() | ||
|
||
await walletModalValidator.expectEoaAddress(NOT_ENABLED_SMART_ACCOUNT_INDEX) | ||
} | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this absolutely required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was preventing the magic disconnect promise from resolving, but shoould work without it.
will push fix in a diff pr if possible