Aborting input registrations: 'WrongPhase' gives "Waiting for confirmed funds" in musicbox

[MarnixCroes]

General Description

I started coinjoin, Waiting for other participants ended
then the message Waiting for confirmed funds was displayed in the musicbox. while all my coins are confirmed.

I checked logs:
INFO CoinJoinClient.CreateRegisterAndConfirmCoinsAsync (406) Round (680fac436000f72ec49d2d4ed40f4f00ce64ac29df96c9fdcca5b49305cf211a): Aborting input registrations: 'WrongPhase'.

it continued normally after a couple seconds

Wasabi Version

2.0.3rc4

[molnard]

I guess the round was load balanced or just aborted for some other reason. This is OK, the coordinator can abort for any reason. The log message could be confusing. Do you see something regarding the reason in the logs?

[MarnixCroes]

I guess the round was load balanced or just aborted for some other reason. This is OK, the coordinator can abort for any reason. The log message could be confusing. Do you see something regarding the reason in the logs?

nothing else in the log,

the issue is more about the incorrect musicbox message though

[wieslawsoltes]

So upon my investigation the Waiting for confirmed fund corresponds to error CoinjoinError.NoCoinsToMix which actually can be 3 different errors:

1. So I see these can be either message ""No coin was selected from candidate coins" but no idea what real reason is or might have been reason "...Probably it was not economical"?

throw new CoinJoinClientException(CoinjoinError.NoCoinsToMix, $"No coin was selected from '{coinCandidates.Count()}' number of coins. Probably it was not economical, total amount of coins were: {Money.Satoshis(coinCandidates.Sum(c => c.Amount))} BTC.");

https://github.com/zkSNACKs/WalletWasabi/blob/e25fea57e6d377ef181d104b036a5cb4af52024f/WalletWasabi/WabiSabi/Client/CoinJoinClient.cs#L170

2. The message maybe should indicate "The coordinator rejected all inputs"or something more user friendly ?

throw new CoinJoinClientException(CoinjoinError.NoCoinsToMix, $"The coordinator rejected all {smartCoins.Count()} inputs.");

https://github.com/zkSNACKs/WalletWasabi/blob/e25fea57e6d377ef181d104b036a5cb4af52024f/WalletWasabi/WabiSabi/Client/CoinJoinClient.cs#L313

3. Possible message "No candidate coins available to mix." for music box ?

throw new CoinJoinClientException(CoinjoinError.NoCoinsToMix, "No candidate coins available to mix.");

https://github.com/zkSNACKs/WalletWasabi/blob/e25fea57e6d377ef181d104b036a5cb4af52024f/WalletWasabi/WabiSabi/Client/CoinJoinManager.cs#L194

Solution:
So to make music box display proper message we would need 3 distinct errors in CoinjoinError and handle those in UI ?

[wieslawsoltes]

Upon further investigation CoinjoinError.AllCoinsPrivate is also used in 3 different district places but is reported as one issue. Might be also confusing for music box messages to users.

1. This actually writes into the log: "All mixed!", while music box message is "Hurray! Your funds are private"
   https://github.com/zkSNACKs/WalletWasabi/blob/e25fea57e6d377ef181d104b036a5cb4af52024f/WalletWasabi/WabiSabi/Client/CoinJoinManager.cs#L186

2. So this error is related to comment "If coin candidates are already private and the user doesn't override the StopWhenAllMixed, then don't mix." so we should probably indicate it to user as comment suggests?
   https://github.com/zkSNACKs/WalletWasabi/blob/e25fea57e6d377ef181d104b036a5cb4af52024f/WalletWasabi/WabiSabi/Client/CoinJoinManager.cs#L200

3. This one actually might not stop the process, it's notifications and might be retried. Seems to be proper message actaully as it's using wallet.IsWalletPrivateAsync()
   https://github.com/zkSNACKs/WalletWasabi/blob/e25fea57e6d377ef181d104b036a5cb4af52024f/WalletWasabi/WabiSabi/Client/CoinJoinManager.cs#L458

[wieslawsoltes]

Possible solution to solve confusing or wrong music box messages related to coin join errors:

1. So I think we might need to split CoinjoinError.NoCoinsToMix into 3 separate errors based on this : Aborting input registrations: 'WrongPhase' gives "Waiting for confirmed funds" in musicbox #10313 (comment)

2. So I think we might need to split CoinjoinError.AllCoinsPrivate into 3 separate errors based on this :
   Aborting input registrations: 'WrongPhase' gives "Waiting for confirmed funds" in musicbox #10313 (comment)

[wieslawsoltes]

I have opened #10697 with quick fix so at least make message closer to the truth :)

[yahiheb]

Possible solution to solve confusing or wrong music box messages related to coin join errors:

1. So I think we might need to split CoinjoinError.NoCoinsToMix into 3 separate errors based on this : Aborting input registrations: 'WrongPhase' gives "Waiting for confirmed funds" in musicbox #10313 (comment)
2. So I think we might need to split CoinjoinError.AllCoinsPrivate into 3 separate errors based on this :
   Aborting input registrations: 'WrongPhase' gives "Waiting for confirmed funds" in musicbox #10313 (comment)

@soosr The 1st one was fixed by #10697, should we do anything regarding the 2nd one?