Explicitly split CoordinatorUri and BackendUri #13087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolay
force-pushed
the
explicitSeparationBackendCoord
branch
from
ed1b448
to
deb8e72
Compare
lontivero
approved these changes
May 27, 2024
molnard
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change anything to the behavior, it simply makes the configs for
CoordinatorUriexplicitHowever,
PersistentConfigdoesn't persist anydefaultconfig. What does it mean? Go to your config file and delete one line, save, launch Wasabi and quit. You will see that the line won't reappear.For this reason, this new config won't appear on old configs, only when it's changed or when the Config is new.
So to test this PR you can delete your config file after a backup and see that now those configs explicitly appears.