Fix headers and footers bug introduced in commit 4b7c6f41e4bda1645eb5… #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think that commit 4b7c6f41e4bda1645eb5b88d9e510348dcf261f3 introduced an unintended side-effect caused by a difference in the syntax of
scrlayer-scrpage
andfancyhdr
.When building a document with the option
oneside
set, I still get two different versions of the headers and footers:In my opinion, this should not be the case. Instead, if
oneside
is set, I should always get the same headers and footers, like this (taken from the version in this pull request):On page 267 of the KOMA-Script manual we can see that
scrlayer-scrpage
only requires two arguments for plainscrheadings
and normalscrheadings
, e. g.\ihead*[plain.scrheadings content]{scrheadings content}
.fancyhdr on the other side requires two arguments for even and odd pages, as can be seen on page 45 of the manual:
Previous versions of Eisvogel (i. e. v 2.0.0) had a completely different plain style for headers and footers (a centered page number in a footer without a rule and no header at all):
If my suspicions about the author's intentions are correct, we can simply replace the code with two arguments with the star-version - as has been done in this pull request.
By the way - this also has the correct behavior if
oneside
is not set: