Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intelligence display sequences not shutting down. #436

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@KJeff01
Copy link
Contributor

commented Jul 8, 2019

Video sequences were not being shut down correctly since 41af29c.

Fixes #431.

Fix intelligence display sequences not shutting down.
Video sequences were not being shut down correctly since 41af29c.

@KJeff01 KJeff01 added this to the 3.3.0_beta2 milestone Jul 8, 2019

@highlander1599

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

This patch made the problem worse. Now the animation is generally not showing. Neither in a newly started Alpha campaign nor in an old save.

@KJeff01

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

This patch made the problem worse. Now the animation is generally not showing. Neither in a newly started Alpha campaign nor in an old save.

I see no problems. Are you sure you are testing this patch and not an older build?

@highlander1599

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

This patch made the problem worse. Now the animation is generally not showing. Neither in a newly started Alpha campaign nor in an old save.

I see no problems. Are you sure you are testing this patch and not an older build?

Appveyor is giving me commit f8175a9 with the portable version. And that's the commit I tested.

@Forgon2100

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

This patch made the problem worse. Now the animation is generally not showing. Neither in a newly started Alpha campaign nor in an old save.

Did you forget to put sequences into your (new) configuration directory?

@highlander1599

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

This patch made the problem worse. Now the animation is generally not showing. Neither in a newly started Alpha campaign nor in an old save.

Did you forget to put sequences into your (new) configuration directory?

Ooops, that was my fault. Now it's working. Sorry for the trouble. :(

@KJeff01 KJeff01 merged commit 070f0c8 into Warzone2100:master Jul 8, 2019

5 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details

@KJeff01 KJeff01 deleted the KJeff01:intelseq branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.