Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash when loading a saved game of a challenge from CLI #439

Merged

Conversation

@topimiettinen
Copy link
Contributor

commented Jul 10, 2019

Closes #437.

@topimiettinen

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Maybe a bigger refactoring should be done later to resolve confusion between sRequestResult and saveGameName. I'd start by introducing setter/getter functions.

@KJeff01 KJeff01 added this to the 3.3.0_beta2 milestone Jul 11, 2019

@KJeff01 KJeff01 merged commit 244fd2c into Warzone2100:master Jul 11, 2019

6 of 8 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
freebsd_build FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
freebsd_build FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.