Technology start tweak. Need review #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaut
force-pushed
the
start_tech
branch
2 times, most recently
from
b8358db
to
0d7154f
Compare
|
Remember to squash smaller changes into one commit again. I'm ok with trying this out for the next release. |
Using the bot, I determined the minimum time to complete the research and put it in allRes The number of start-up technologies issued has replaced the time by which these technologies are available. timeBaseTech = 4.5 * 60; timeAdvancedBaseTech = 7.9 * 60; timeT2 = 17 * 60; timeT3 = 25 * 60;
KJeff01
reviewed
Apr 4, 2020
| completeResearch(tech[i], c); | ||
| } | ||
| } | ||
| for ( var tech in allRes) |
KJeff01
reviewed
Apr 4, 2020
| { | ||
| if (allRes[tech] <= time) | ||
| { | ||
| completeResearch (tech, playnum); |
There was a problem hiding this comment.
Extra space before left parenthesis.
KJeff01
reviewed
Apr 4, 2020
| enableResearch(tech[i], c); | ||
| } | ||
| } | ||
| var allRes= { |
There was a problem hiding this comment.
Add a space before the equals sign.
KJeff01
reviewed
Apr 4, 2020
| "R-Defense-Rail3": 4058, | ||
| "R-Defense-WallTower-Rail3": 4124, | ||
| "R-Defense-MassDriver": 4664, | ||
| "R-Vehicle-Body14": 4734 | ||
| } |
There was a problem hiding this comment.
Add a semicolon after right curly brace.
KJeff01
reviewed
Apr 4, 2020
data/mp/multiplay/skirmish/rules.js
Outdated
| else if (techLevel == 3) | ||
| { | ||
| completeResearchOnTime(timeT3, playnum); | ||
|
|
|
Will merge after you fix the small formatting issues. |
maxsupermanhd
added a commit
to maxsupermanhd/warzone2100
that referenced
this pull request
Apr 5, 2020
This reverts commit f7f33be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopening #682 I apologize for the inconvenience, I mistakenly made the last pull from the master, which caused problems.
The essence of the problem:
When starting in different modes, research are strongly shifted relative to each other. This makes it impossible to create balance in principle. That is good in one mode, it will be broken in another.
My decision:
Determine the minimum opening time for all research and issue all technologies open until a certain time.
The disadvantages of this approach:
For improvement, I do not have enough API to change the time of research. Also, I did not find a way to determine the total time needed to complete the research.
Bot that calculates research time: https://gist.github.com/vaut/4b1747db286b2574f8e4b0d7bfa56a20
Research table https://docs.google.com/spreadsheets/d/1lQ_SqX8dqTsJVD0t61y--klIsKf0zUbP2N5jniu-BIs/edit?usp=sharing add start time and full name resarch