s3: specifying bucket region causes Container() to return non-existent containers

[colemickens]

If you specify S3_REGION then the code path never actually seems to query s3 for the existence of the bucket....

[colemickens]

try this:

S3_ACCESS_KEY_ID=redact
S3_SECRET_KEY=redact
S3_REGION=us-west-2

and try to get a location.Container("non-existent") and it will return successfully

try this:

S3_ACCESS_KEY_ID=redact
S3_SECRET_KEY=redact

and it now queries for the bucket region at the end of the function and errors out.

[colemickens]

fix is here: colemickens@d077919#diff-dd65194c93a22b03112f6701be7b9ad784706bdb374cc5b2d9f8ffe56b480564

[colemickens]

note: this fix doesn't cover another case I've discovered: if you set endpoint + region, it similarly fails to do the region check. This seems somewhat intentional, maybe due to other providers not having the region concept?

[jeevb]

Would it make sense to call HeadBucket to verify the existence of the container before returning it in these cases: https://docs.aws.amazon.com/sdk-for-go/api/service/s3/#S3.HeadBucket?