Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example] Update wit-bindgen version from 0.7.0 to 0.11.0 #2770

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

michael1017
Copy link
Collaborator

To successfully install wit-bindgen using cargo, update the wit-bindgen version in Cargo.toml from 0.7.0 to 0.11.0

Copy link
Member

juntao commented Sep 4, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 1c39e2c2ad8d68518f67a2a47d109304d702192a

This pull request (PR) pertains to a single-file change in the cargo.toml of the 'wasi-logging' plugin under examples located in the repository.

The PR offers an upgrade from wit-bindgen version from 0.7.0 to 0.11.0. It intends to update the dependency to the newer version of the wit-bindgen library which is version 0.11.0.

In terms of potential problems, important things to consider are:

  1. Compatibility Issues: The codebase must be tested to ensure it is compatible with the updated version of wit-bindgen (0.11.0). It is possible that changes have been made in this newer version that could potentially break functionality or cause regressions within the existing software.
  2. Testing: Even if there's no known compatibility issue, it's important to conduct thorough testing to ensure the system's integrity after the update. This may include unit testing, integration testing, and regression testing.
  3. Missing new line at EOF: There is no new line character at the end of the file. Many tools might display or process these files incorrectly or consider it as a change in the last line. To maintain POSIX compliance and prevent unnecessary diff, it's recommended to add a new line character at the end of the file.

Signed-off-by: michael1017 <michael881017@gmail.com>
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2770 (63d6331) into master (58a6d43) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2770      +/-   ##
==========================================
+ Coverage   80.96%   80.98%   +0.01%     
==========================================
  Files         148      148              
  Lines       21592    21592              
  Branches     4338     4338              
==========================================
+ Hits        17482    17486       +4     
+ Misses       2946     2943       -3     
+ Partials     1164     1163       -1     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hydai hydai merged commit 4e702bd into WasmEdge:master Sep 11, 2023
46 of 47 checks passed
sarrah-basta pushed a commit to sarrah-basta/WasmEdge that referenced this pull request Oct 20, 2023
)

Signed-off-by: michael1017 <michael881017@gmail.com>
Signed-off-by: Sarrah Bastawala <sarrah.basta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants