[CMake] Merge and move the simdjson fetching. #3426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. |
github-actions
bot
added
c-Plugin
hydai
approved these changes
May 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3426 +/- ##
=======================================
Coverage 79.84% 79.84%
=======================================
Files 253 253
Lines 34948 34948
Branches 6140 6141 +1
=======================================
Hits 27905 27905
- Misses 5614 5623 +9
+ Partials 1429 1420 -9 ☔ View full report in Codecov by Sentry. |
q82419
force-pushed
the
yiying/cmake_simdjson
branch
from
e69cc89
to
9ec5d54
Compare
|
@q82419 Windows failed. |
q82419
force-pushed
the
yiying/cmake_simdjson
branch
2 times, most recently
from
e6b233e
to
a2e2aa4
Compare
Signed-off-by: YiYing He <yiying@secondstate.io>
q82419
force-pushed
the
yiying/cmake_simdjson
branch
from
a2e2aa4
to
38c7dc3
Compare
hydai
approved these changes
May 27, 2024
dm4
pushed a commit
that referenced
this pull request
Jul 2, 2024
Signed-off-by: YiYing He <yiying@secondstate.io>
dm4
pushed a commit
that referenced
this pull request
Jul 2, 2024
Signed-off-by: YiYing He <yiying@secondstate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.