Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update repo URL in docs to https://github.com/weymouth/WaterLily.jl #21

Merged
merged 1 commit into from
Aug 21, 2021
Merged

Fix: Update repo URL in docs to https://github.com/weymouth/WaterLily.jl #21

merged 1 commit into from
Aug 21, 2021

Conversation

kimlaberinto
Copy link
Contributor

@kimlaberinto kimlaberinto commented Aug 21, 2021 •
edited

Closes #20

This PR updates the Documenter.jl script to point to the new URL for the repo.

@kimlaberinto kimlaberinto mentioned this pull request Aug 21, 2021
Closed
weymouth
weymouth approved these changes Aug 21, 2021
View reviewed changes
Copy link
Collaborator

@weymouth weymouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I didn't catch that.

@weymouth weymouth merged commit 0137bb6 into WaterLily-jl:master Aug 21, 2021
@weymouth
Copy link
Collaborator

Now all of the source tags are pointing to the repo instead of 404. Improvement, but shouldn't they point to the part of each file in the src folder where each function is defined? Do you know how to get that working @kimlaberinto?

@kimlaberinto kimlaberinto deleted the kpl/update_docs_repo_url branch August 22, 2021 01:01
@kimlaberinto kimlaberinto mentioned this pull request Aug 23, 2021
Closed
@kimlaberinto
Copy link
Contributor Author

kimlaberinto commented Aug 23, 2021 •
edited

I was wondering the same thing as well! I'm not completely sure yet, but I've been digging around I do have some thoughts that can be found in the new issue I've made to keep track of this.

New issue with rationale/thinking:
#22

New PR:
#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weymouth weymouth weymouth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs are pointing to wrong/old repo URL
2 participants
@kimlaberinto @weymouth