Implemented YukonEnergyClient #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upper and lower datetime ranges for load and generation data are handled with meaningful logging at WARN level.
This type of functionality, reading static response content from the fixtures directory is done in many unit tests in some form or another. I refactored test_pei.py to use it and intend on using it with test_nspower.py for NSPowerClient. We can gradually refactor other classes to make use of the centralized function as well.
It's a little bit copy/paste but the two implementations should start to diverge from here.
…or YukonEnergyClient
r24mille
changed the title
# Conflicts: # pyiso/nspower.py # tests/unit/test_nspower.py
# Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation adds the
YUKONbalancing authority. Supported data includes:get_load(...)up to 24 hours in the past through the start of the current hour.get_generation(...)up to 24 hours in the past through the start of the current hour.get_trade(...)which will split the requested time range up into hours and always return zero. Yukon Energy is an isolated grid.Closes #128.