Initialize Way Lab EM morphology Tokyo bucket #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwaybio
approved these changes
Mar 4, 2024
falquaddoomi
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Nice! I assume this is nearly identical to the gc-cloud-storage-bucket template, so I didn't get too into reviewing parts I think I've already reviewed before. Let me know if you'd like me to review (or re-review) them in more detail, though.
As you noted in your comment, you're not downloading the service account keyfile any more, so I left a few comments on places where it's still referenced.
Co-Authored-By: Faisal Alquaddoomi <faisal.alquaddoomi@cuanschutz.edu>
|
Thank you @gwaybio and @falquaddoomi for your reviews! Made some changes, and merging this in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initializes a new bucket focused on helping facilitate data transfer of EM data from collaborators in Tokyo. It leveraged the cookiecutter template found here with a few modifications. In this case, the collaborators all have Google accounts, so we do not need the key-based functionality from the template.
CC @falquaddoomi, @MikeLippincott