Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #37

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Update docs #37

merged 4 commits into from
Aug 30, 2023

Conversation

roshankern
Copy link
Member

This PR has two important documentation updates:

  1. Make very clear which code is using multi class models and what code is using single class models in evaluate models.
  2. Clarify that folded phenotypic class is not used throughout this repo.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@roshankern
Copy link
Member Author

This PR is ready for review!

Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I added one small question to see if it provides more clarity to the README but other than please feel free to merge!

0.download_data/README.md Outdated Show resolved Hide resolved
@roshankern roshankern merged commit 456471e into WayScience:main Aug 30, 2023
@roshankern roshankern deleted the update-docs branch August 30, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants