-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom rendering doesn't work in some setups #3
Comments
Does animate plugin work(provides animation when a window is opened/closed)? Or you see a flicker(gray screen instead of animation) when you open an app? If this is the case, then the whole custom rendering is to blame. |
I get a flicker on opening or closing any and all windows |
@lukefromdc Will you be able to help me debug it (possibly later)? If yes, then PM me in gitter when you've got some time to spare, because on my 2 laptops I haven't been able to reproduce the issue. |
I can certainly test any changes, but don't know enough about the Wayland code or OpenGL to write much for this yet |
Wonder if this is a hardware/OpenGL issue? I am on radeon/r600g open source drivers on a Radeon HD6750 graphics card, and your laptop is probably something different. |
well, it most likely is graphics. I made a guess at what was wrong, can you test the debug branch? UPD: I actually disabled transparency, so perhaps you'll see some wrong rendering but at least there shouldn't be flickering when opening apps and (at least) expo should work. That is, if my hypothesis is correct. If there is no change, then please recompile with debugging enabled(https://github.com/ammen99/wayfire/wiki/Debugging-problems) and send me a log to see if we can learn something. |
Same behavior in debug branch, flicker is to black. Also, turning on full animations with KEY_TAB causes the screen to stay black. |
Still no response from expo with this setup in the .ini file:
but CONFIRM that disabling animation stops the flickers. Didn't get any debugging text at all in the logfire on trying those build options for some reason though. In general behavior seemed exactly the same with either branch and any build |
The missing output from the logfile is strange. Are you sure you installed wayfire at the correct location(e.g when you compiled first you installed in /usr/bin, but the second time with debug in /usr/local/bin)? Otherwise you should get at least some output from libweston in the logfile. |
Confirm, installation is in /usr/bin and no sign of anything from wayfire in /usr/local/bin. With no make uninstall target, what is installed stays in the filesystem unless manually removed or installed by building a debian package and then removed. I did get some output from Caja when run with --force-desktop from within wayfire, just no output from wayfire itself, and no debugging looking output on the console either |
Hi, I finally managed to reproduce the bug on my friend's laptop. Please test the newest commit in the debug branch. Also don't forget to pull latest commits from patched libweston repo. |
I can confirm the latest changes fix animation in and only in the debug branch. No more flicker, windows open in zoom mode as now configured |
Cube works, tile works, shortcuts are enough different from compiz to be a bit counter-intuitive. I have yet to figure out how to activage expo, but with the debug branch the main issue (might be limited to debug) is sometimes getting a rendering/redraw issue in Xwayland windows that have been tiled. |
Which tiling do you use (tile or grid plugin)? For grid you can change them the way you want, but tile is still in progress. About expo: did you set a keybinding in the [expo] section (activate= KEY_E is the default)? It seems I forgot to include it in the default config. The redraw issue: what does that mean? Bad pixels? The window doesn't update? When is it happening(in grid, tile? while resizing? or after they've been configured)? |
Redraw issue was many old partial copies overlapping of an Xwayland window that had been tiled and then moved, did not happen all the time. Keybindings I tried for Expo before did not work, will test that some more. Not sure whether grid or tile was in use, but was able to pull windows to edge to tile them. The ini file is only slightly modified |
The redraw issue seems like a background/panel crash. Can you send a screenshot(super+S and the screenshot is saved in ~/Pictures) |
This section in the .ini file for expo generated no results:
|
mm, expo can only be activated with a keybinding for now |
Could not duplicate background issue right now, maybe something else had to crash first? |
Yes, I think that the trailing issue is like what you could get in Windows XP, and that is because background+shell crashed. Another item in TODO: split background and panel |
activate = KEY_RIGHT did not work either for expo |
Just pull the debug branch again and try(no need for libweston) |
That works, I did not know expo had a different name for activation. Very smooth and nice running, this is still the debug branch of course. |
I didn't know it also :P Glad to hear it works, what resolution do you use? Because I spent some time optimizing Expo, and now it works on my 1920x1080, but I wonder if my optimizations are enough for 4K? |
Something that came to my mind: If panel crashes relatively often, then you can try running it under gdb to be able to get a backtrace when it crashes. |
I normally have two monitors available: a 1080X1920 and a smaller 1024X768 that is normally turned off when not in use, but in a Wayland session both come up. I get a separate cube or expo for each screen, the active screen (last one clicked with the mouse) being the one the effect is applied to. I don't own any 4K hardware at all |
Anyway, it seems that this issue has been resolved, I'll close it. If you encounter crash from panel again, please open another issue. |
Has the fix been moved to master from the debug branch? |
You are welcome, now I know how to build this and you know what not to worry about |
winshadows: deinit_view when view is unmapped
I don't know if its just my .ini file but on my setup on Debian Unstable and AMD r600g drivers I have not been able to get the desktop cube or expo to show by setting any keybinding as "activate."
EDIT: nothing brings them up with the default, unmodified .ini file either
The text was updated successfully, but these errors were encountered: