Center-view plugin #10

AdrianVovk · 2018-06-09T20:16:46Z

A plugin to open all normal windows in the center of the screen instead of the top-left corner.

ammen99

As we said in IRC, this looks good, it's just minor style fixes so it looks like the rest of the code in the repo. Also in the end squash your commits together so it is a single commit.

ammen99 · 2018-06-09T20:27:18Z

plugins/single_plugins/center-view.cpp

+	signal_callback_t created_cb;
+
+	public:
+	void init(wayfire_config *config) {


code style: brace on the next line

ammen99 · 2018-06-09T20:27:26Z

plugins/single_plugins/center-view.cpp

+		created_cb = [=] (signal_data *data)
+		{
+			auto view = get_signaled_view(data);
+			if (view->role == WF_VIEW_ROLE_TOPLEVEL && !view->parent) {


code style: brace on the next line

ammen99 · 2018-06-09T20:27:41Z

plugins/single_plugins/center-view.cpp

+};
+
+extern "C" {
+	wayfire_plugin_t *newInstance() {


code style: brace on the next line

On the extern C? Or on the newInstance?

ammen99 · 2018-06-09T20:27:51Z

plugins/single_plugins/center-view.cpp

+	}	
+};
+
+extern "C" {


code style: brace on the next line

ammen99 · 2018-06-09T20:28:08Z

plugins/single_plugins/meson.build

@@ -12,3 +12,4 @@ oswitch       = shared_module('oswitch',       'oswitch.cpp',       include_dire
 rotator       = shared_module('rotator',       'rotator.cpp',       include_directories: [wayfire_api_inc, wayfire_conf_inc], dependencies: [wlroots, pixman, wfconfig], install: true, install_dir: 'lib/wayfire/')
 apps_logger   = shared_module('apps-logger',   'apps-logger.cpp',   include_directories: [wayfire_api_inc, wayfire_conf_inc], dependencies: [wlroots, pixman, wfconfig], install: true, install_dir: 'lib/wayfire/')
 window_rules  = shared_module('window-rules',  'window-rules.cpp',  include_directories: [wayfire_api_inc, wayfire_conf_inc], dependencies: [wlroots, pixman, wfconfig], install: true, install_dir: 'lib/wayfire/')
+center_view  = shared_module('center-view',  'center-view.cpp',  include_directories: [wayfire_api_inc, wayfire_conf_inc], dependencies: [wlroots, pixman, wfconfig], install: true, install_dir: 'lib/wayfire/')


add another space so they line up :)
actually in the other columns as well

ammen99 · 2018-06-09T20:29:20Z

plugins/single_plugins/center-view.cpp

+				wf_geometry window = view->get_wm_geometry();
+				window.x = (workarea.width / 2) - (window.width / 2);
+				window.y = (workarea.height / 2) - (window.height / 2);
+				view->move (window.x, window.y);


remove the space between "move" and (

Whoops I've been using too much vala

Also some C++ codebases use it, it's a matter of preference (but code throughout a single codebase should generally follow the same style of course)

ammen99

A few things I missed before, sorry to bother you again

ammen99 · 2018-06-10T04:52:28Z

plugins/single_plugins/meson.build

@@ -12,3 +12,4 @@ oswitch       = shared_module('oswitch',       'oswitch.cpp',       include_dire
 rotator       = shared_module('rotator',       'rotator.cpp',       include_directories: [wayfire_api_inc, wayfire_conf_inc], dependencies: [wlroots, pixman, wfconfig], install: true, install_dir: 'lib/wayfire/')
 apps_logger   = shared_module('apps-logger',   'apps-logger.cpp',   include_directories: [wayfire_api_inc, wayfire_conf_inc], dependencies: [wlroots, pixman, wfconfig], install: true, install_dir: 'lib/wayfire/')
 window_rules  = shared_module('window-rules',  'window-rules.cpp',  include_directories: [wayfire_api_inc, wayfire_conf_inc], dependencies: [wlroots, pixman, wfconfig], install: true, install_dir: 'lib/wayfire/')
+center_view  =  shared_module('center-view',   'center-view.cpp',   include_directories: [wayfire_api_inc, wayfire_conf_inc], dependencies: [wlroots, pixman, wfconfig], install: true, install_dir: 'lib/wayfire/')


please align the = as well

ammen99 · 2018-06-10T04:52:52Z

plugins/single_plugins/center-view.cpp

@@ -0,0 +1,36 @@
+#include <output.hpp>
+#include <core.hpp>


do you need that include?

Probably not, but what provides Wayfire_plugin_t?

@ammen99 How is it working then? I'm not including that

some headers require others, e.g they aren't always self-contained

ammen99 · 2018-06-10T04:53:31Z

src/output/output.cpp

@@ -51,7 +51,7 @@ static wl_output_transform get_transform_from_string(std::string transform)
    else if (transform == "180")
        return WL_OUTPUT_TRANSFORM_180;
    else if (transform == "270")
-        return WL_OUTPUT_TRANSFORM_180;
+        return WL_OUTPUT_TRANSFORM_270;


why is that in this PR? maybe I forgot to push something

Idk. I think it merged in some commit at some point...

yeah if you rebase it should automatically drop this since it isn't part of this PR

AdrianVovk · 2018-06-11T02:48:12Z

I've redone the commit again. Check it out again

ammen99 · 2018-06-11T05:09:08Z

Thanks!

Add benchmark plugin

ammen99 reviewed Jun 9, 2018

View reviewed changes

AdrianVovk force-pushed the split-files branch from dd560c0 to 36f4e68 Compare June 9, 2018 20:40

ammen99 reviewed Jun 10, 2018

View reviewed changes

AdrianVovk force-pushed the split-files branch from 06578c2 to 0a47c91 Compare June 11, 2018 02:43

Create plugin to start windows in the center

fc228f7

AdrianVovk force-pushed the split-files branch from 0a47c91 to fc228f7 Compare June 11, 2018 05:05

ammen99 merged commit d61dc90 into WayfireWM:split-files Jun 11, 2018

soreau mentioned this pull request Mar 20, 2020

output-layout: Don't emit configuration changed signal when shutting down #441

Closed

ammen99 mentioned this pull request Sep 2, 2020

Crash on exit if window is wobblying #718

Closed

AdrianVovk deleted the split-files branch August 16, 2021 05:03

luoshenzhi mentioned this pull request Apr 5, 2022

Error when starting wayfire: Assertion `handle || is_shutting_down()' failed. #1451

Closed

Kim-Dewelski pushed a commit to Kim-Dewelski/wayfire that referenced this pull request Dec 15, 2023

Merge pull request WayfireWM#10 from WayfireWM/benchmark

9015168

Add benchmark plugin

solunix mentioned this pull request Jan 17, 2024

Chromium File-Dialog Segfault Wayfire #2100

Closed

killown mentioned this pull request Feb 16, 2024

Random Crash #2145

Closed

spl237 mentioned this pull request Feb 19, 2024

Closing windows with plugin decoration on touchscreen causes a segfault #2150

Closed

dagbdagb mentioned this pull request Feb 20, 2024

segfault on 'rectangle selection' in kitty, if cube plugin is enabled #2155

Closed

This was referenced Feb 27, 2024

Hexchat settings crashing wayfire #2168

Closed

xdg_popup crash #2175

Closed

This was referenced Mar 11, 2024

crash after disable scale plugin and toggle scale #2199

Closed

Turning off a display with views will crash wayfire [*Critial BUG*] #2201

Closed

Expo lag will crash wayfire #2203

Open

[wcm] Plugin load/unload sometimes will crash wayfire #2204

Closed

This was referenced Mar 13, 2024

Crash in wayfire-shell plugin when unplugging external monitor #2212

Closed

Wf-backgroud crashes after disconnecting external monitor. WayfireWM/wf-shell#219

Closed

This was referenced Mar 16, 2024

Mouse confinement will cause Wayfire to crash after turning off/on the monitor. #2223

Closed

Scale plugin: wayfire crash while drag and move a view between monitors #2236

Closed

simple tile bug (wayfire crash) #2239

Closed

killown mentioned this pull request Mar 28, 2024

Wayfire crash with output workarea manager #2284

Closed

ssfdust mentioned this pull request Jun 16, 2024

Cairo-dock popup cause wayfire to crash #2381

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Center-view plugin #10

Center-view plugin #10

AdrianVovk commented Jun 9, 2018 •

edited

Loading

ammen99 left a comment

ammen99 Jun 9, 2018

ammen99 Jun 9, 2018

ammen99 Jun 9, 2018

AdrianVovk Jun 9, 2018

ammen99 Jun 9, 2018

ammen99 Jun 9, 2018

ammen99 Jun 9, 2018

ammen99 Jun 9, 2018

AdrianVovk Jun 9, 2018

ammen99 Jun 9, 2018

ammen99 left a comment

ammen99 Jun 10, 2018

ammen99 Jun 10, 2018

AdrianVovk Jun 10, 2018

ammen99 Jun 10, 2018

AdrianVovk Jun 10, 2018

ammen99 Jun 10, 2018

ammen99 Jun 10, 2018

AdrianVovk Jun 10, 2018

ammen99 Jun 10, 2018

AdrianVovk commented Jun 11, 2018

ammen99 commented Jun 11, 2018

Center-view plugin #10

Center-view plugin #10

Conversation

AdrianVovk commented Jun 9, 2018 • edited Loading

ammen99 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ammen99 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AdrianVovk commented Jun 11, 2018

ammen99 commented Jun 11, 2018

AdrianVovk commented Jun 9, 2018 •

edited

Loading