im-v1: send null preedit_string if it's empty #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes GTK to emit preedit-end signals so that vte paints its cursor. The preedit_string from input-method-v1 can't be null.
ammen99
approved these changes
Mar 7, 2024
|
PS: GNOME does this. KDE ignores it and a following There is a related issue fcitx/fcitx5#514 but for input-method-v2. |
ammen99
pushed a commit
that referenced
this pull request
Mar 9, 2024
This makes GTK to emit preedit-end signals so that vte paints its cursor. The preedit_string from input-method-v1 can't be null.
ammen99
pushed a commit
that referenced
this pull request
Mar 9, 2024
This makes GTK to emit preedit-end signals so that vte paints its cursor. The preedit_string from input-method-v1 can't be null.
ammen99
pushed a commit
that referenced
this pull request
Mar 13, 2024
This makes GTK to emit preedit-end signals so that vte paints its cursor. The preedit_string from input-method-v1 can't be null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes GTK to emit preedit-end signals so that vte paints its cursor. The preedit_string from input-method-v1 can't be null.