Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotspot support #841

Merged
merged 4 commits into from
Nov 17, 2020
Merged

hotspot support #841

merged 4 commits into from
Nov 17, 2020

Conversation

ammen99
Copy link
Member

@ammen99 ammen99 commented Oct 31, 2020

This PR adds basic support for hotspots. The required changes for wf-config are not merged yet,
see https://github.com/WayfireWM/wf-config/tree/add-hotspots.

Hotspots are currently supported as part of activator bindings. For example,

[expo]
toggle = hotspot top-left 100x10 1000

The meaning of the example: the hotspot is in the top-left corner.
It spawns an area of 100 pixels along both edges, with a "width" of 10 pixels, i.e. the same as explained
here: #572

The last parameter means that the cursor needs to stay for 1000 milliseconds in the hotspot to activate it.

Fixes #298

@ammen99 ammen99 marked this pull request as draft October 31, 2020 12:31
@damianatorrpm
Copy link
Contributor

damianatorrpm commented Oct 31, 2020

I'm building now with this as well to test, after thinking about it,
it would make more sense to not do special fullscreen handling here,
but instead for example scale (the only plugin I care w/hotspots for)
to have an option to deny these request if the activator source is hotspot.

@damianatorrpm
Copy link
Contributor

damianatorrpm commented Nov 1, 2020

works fine with the exception that changing options to a hotspot requires wayfire restart
at runtime changing

[scale]
toggle = <super> | hotspot top-left 10x100 100

to

[scale]
toggle = <super> | hotspot bottom-left 10x100 100

has no effect

@ammen99
Copy link
Member Author

ammen99 commented Nov 1, 2020

works fine with the exception that changing options to a hotspot requires wayfire restart
at runtime changing

Ah yes I forgot to recreate hotspots on config reload, I'll fix it.

@damianatorrpm
Copy link
Contributor

hotspot reload still doesn't work

[scale]
toggle = <super> | hotspot top-left 10x100 100

to

[scale]
toggle = <super> | hotspot bottom-left 10x100 100

I used branch hotspot-support for build or do other things need to applied (except wf-config)

@ammen99
Copy link
Member Author

ammen99 commented Nov 14, 2020

@damianatorrpm I think I fixed the reloading issue, can you try again? (also update wf-config because the bug was there, the fix was pushed on the same branch)

@ammen99 ammen99 marked this pull request as ready for review November 14, 2020 22:11
@damianatorrpm
Copy link
Contributor

@ammen99 Yep, work fine

Otherwise, we are recreating them each time an activator is added or
removed which can happen many times consecutively. Instead, we should
reload on the next idle, in order to group such changes together.
Needed for hotspot support.
@ammen99 ammen99 merged commit 5270795 into master Nov 17, 2020
@ammen99 ammen99 deleted the hotspot-support branch November 17, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add hotcorner support
2 participants