Reload window-rules on config change #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammen99
reviewed
Nov 20, 2020
| wf::lexer_t _lexer; | ||
|
|
||
| wf::signal_callback_t _created; | ||
| wf::signal_callback_t _maximized; | ||
| wf::signal_callback_t _unmaximized; | ||
| wf::signal_callback_t _minimized; | ||
| wf::signal_callback_t _fullscreened; | ||
| wf::signal_callback_t reload_config; |
There was a problem hiding this comment.
A small thing: wf::signal_callback_t is deprecated, new code should use wf::signal_connection_t (and also whenever possible, please initialize lambda as soon as you declare it, I think it should be possible here).
There was a problem hiding this comment.
Ah I see. I will make changes and make a commit when I'm a little free. I more or less copied the code from commands plugin.
ammen99
reviewed
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the
window-rulesplugin to auto-reload all the rules when config file is modified without having to restart wayfire.